Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dead code analysis inside for loops #3731

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Jan 14, 2024

What I did

fixes #3223

(depends #3541)

How I did it

recurse into loop bodies when For nodes are encountered.

How to verify it

Commit message

unreachable code analysis did not analyze for loop bodies.
fix: in `find_terminating_node()`, recurse into the bodies of for loops.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (af5c49f) 84.16% compared to head (9f99147) 84.20%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3731      +/-   ##
==========================================
+ Coverage   84.16%   84.20%   +0.03%     
==========================================
  Files          92       92              
  Lines       13133    13135       +2     
  Branches     2926     2927       +1     
==========================================
+ Hits        11054    11060       +6     
+ Misses       1659     1655       -4     
  Partials      420      420              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper charles-cooper merged commit 81c6d8e into vyperlang:master Jan 15, 2024
84 checks passed
@charles-cooper charles-cooper deleted the fix/terminating-for branch January 15, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exit statements with succeeding code not prevented in For loops.
4 participants