-
-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rename vyper.interfaces
to ethereum.ercs
#3741
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3741 +/- ##
==========================================
+ Coverage 84.78% 84.80% +0.02%
==========================================
Files 92 92
Lines 13139 13139
Branches 2929 2929
==========================================
+ Hits 11140 11143 +3
+ Misses 1535 1532 -3
Partials 464 464 ☔ View full report in Codecov by Sentry. |
vyper.interfaces
to ethereum.ercs
this seems fine. do we want ERC20, ERC721, etc or IERC20, IERC721, etc? @fubuloubu |
ERC20, ERC721, etc. Unfortunately it seems like the masses prefer it, and it has also grown on me, although do we risk namespace collisions with other libs if the stdlib is canonically taking up |
It's namespaced behind a module, so can always rename the import |
As is e.g. |
vyper.interfaces
to ethereum.ercs
vyper.interfaces
to ethereum.ercs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
What I did
Fixed Issue #3675
How I did it
Honestly I just found and replaced, and it didn't break(??). Would double check but this seems to be working to me
How to verify it
Run the tests, they seem to pass?
Commit message
Aliased
vyper.interfaces
import toethereum.ercs
Description for the changelog
Aliased
vyper.interfaces
import toethereum.ercs
Cute Animal Picture
This is who you're bullying when your request changes on my PR (jk ... pls do whatever is necessary)