Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename vyper.interfaces to ethereum.ercs #3741

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

ControlCplusControlV
Copy link
Contributor

What I did

Fixed Issue #3675

How I did it

Honestly I just found and replaced, and it didn't break(??). Would double check but this seems to be working to me

How to verify it

Run the tests, they seem to pass?

Commit message

Aliased vyper.interfaces import to ethereum.ercs

Description for the changelog

Aliased vyper.interfaces import to ethereum.ercs

Cute Animal Picture

This is who you're bullying when your request changes on my PR (jk ... pls do whatever is necessary)
image

@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (55e18f6) 84.78% compared to head (36dcab9) 84.80%.
Report is 3 commits behind head on master.

❗ Current head 36dcab9 differs from pull request most recent head 8434193. Consider uploading reports for the commit 8434193 to get more accurate results

Files Patch % Lines
vyper/semantics/analysis/module.py 66.66% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3741      +/-   ##
==========================================
+ Coverage   84.78%   84.80%   +0.02%     
==========================================
  Files          92       92              
  Lines       13139    13139              
  Branches     2929     2929              
==========================================
+ Hits        11140    11143       +3     
+ Misses       1535     1532       -3     
  Partials      464      464              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ControlCplusControlV ControlCplusControlV changed the title fixed issue #3675 feat: Renamed vyper.interfaces to ethereum.ercs Jan 30, 2024
@charles-cooper
Copy link
Member

this seems fine. do we want ERC20, ERC721, etc or IERC20, IERC721, etc? @fubuloubu

@ControlCplusControlV
Copy link
Contributor Author

ERC20, ERC721, etc. Unfortunately it seems like the masses prefer it, and it has also grown on me, although do we risk namespace collisions with other libs if the stdlib is canonically taking up ERC20?

@fubuloubu
Copy link
Member

ERC20, ERC721, etc. Unfortunately it seems like the masses prefer it, and it has also grown on me, although do we risk namespace collisions with other libs if the stdlib is canonically taking up ERC20?

It's namespaced behind a module, so can always rename the import

@fubuloubu
Copy link
Member

this seems fine. do we want ERC20, ERC721, etc or IERC20, IERC721, etc? @fubuloubu

As is e.g. ERC20

@charles-cooper charles-cooper changed the title feat: Renamed vyper.interfaces to ethereum.ercs feat: rename vyper.interfaces to ethereum.ercs Jan 31, 2024
Copy link
Member

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@charles-cooper charles-cooper merged commit db8ac3c into vyperlang:master Jan 31, 2024
84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants