Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove Index AST node #3757

Merged
merged 10 commits into from
Feb 5, 2024
Merged

Conversation

tserg
Copy link
Collaborator

@tserg tserg commented Feb 4, 2024

What I did

Deprecate Index AST node.

How I did it

How to verify it

Commit message

remove Index AST node type, it has been deprecated from the python AST
since python3.9.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

vyper/semantics/types/base.py Dismissed Show dismissed Hide dismissed
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (db8ac3c) 84.78% compared to head (8fe6e7d) 84.75%.
Report is 1 commits behind head on master.

❗ Current head 8fe6e7d differs from pull request most recent head a99e541. Consider uploading reports for the commit a99e541 to get more accurate results

Files Patch % Lines
vyper/semantics/types/subscriptable.py 60.00% 0 Missing and 2 partials ⚠️
vyper/codegen/expr.py 66.66% 1 Missing ⚠️
vyper/semantics/analysis/utils.py 80.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3757      +/-   ##
==========================================
- Coverage   84.78%   84.75%   -0.04%     
==========================================
  Files          92       92              
  Lines       13141    13128      -13     
  Branches     2930     2929       -1     
==========================================
- Hits        11142    11126      -16     
- Misses       1535     1539       +4     
+ Partials      464      463       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@charles-cooper charles-cooper marked this pull request as ready for review February 5, 2024 14:40
@charles-cooper charles-cooper changed the title feat: deprecate Index AST node feat: remove Index AST node Feb 5, 2024
@charles-cooper charles-cooper enabled auto-merge (squash) February 5, 2024 14:42
@charles-cooper charles-cooper merged commit 01ec9a1 into vyperlang:master Feb 5, 2024
84 checks passed
@tserg tserg deleted the feat/remove_index branch February 5, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants