Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve exception for type validation #3759

Merged
merged 4 commits into from
Feb 8, 2024

Conversation

tserg
Copy link
Collaborator

@tserg tserg commented Feb 6, 2024

What I did

Change the exception for validate_expected_type from InvalidType to TypeMismatch.

How I did it

How to verify it

Commit message

chore: change exception type for type validation

This PR changes the exception raised for `validate_expected_type`
from `InvalidType` to `TypeMismatch`.

Description for the changelog

Change exception type for for type validation.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e20885e) 84.78% compared to head (6808495) 84.78%.
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3759   +/-   ##
=======================================
  Coverage   84.78%   84.78%           
=======================================
  Files          92       92           
  Lines       13122    13129    +7     
  Branches     2933     2934    +1     
=======================================
+ Hits        11125    11132    +7     
  Misses       1534     1534           
  Partials      463      463           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tserg tserg marked this pull request as ready for review February 7, 2024 14:21
Copy link
Member

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thanks!

@charles-cooper charles-cooper merged commit c6b29c7 into vyperlang:master Feb 8, 2024
84 checks passed
@tserg tserg deleted the chore/change_exc branch February 9, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants