Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more frontend optimizations #3785

Merged
merged 17 commits into from
Feb 19, 2024

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Feb 17, 2024

What I did

How I did it

How to verify it

Commit message

- optimize `VyperNode.get_descendants()` and `get_children()`
- get rid of `sort_nodes()`, we can guarantee ordering the old fashioned
  way (topsort)
- optimize `VyperNode.__hash__()` and `VyperNode.__init__()`
- optimize `IntegerT.compare_type()`

optimizes front-end compilation time by another 25%

Description for the changelog

Cute Animal Picture

image

optimize get_descendants and get_children
get rid of sort_nodes, we can guarantee ordering the old fashioned way
optimize VyperNode.__hash__
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2d2a682) 84.99% compared to head (01ec986) 84.98%.
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3785      +/-   ##
==========================================
- Coverage   84.99%   84.98%   -0.02%     
==========================================
  Files          92       92              
  Lines       13717    13717              
  Branches     3079     3077       -2     
==========================================
- Hits        11659    11657       -2     
- Misses       1570     1571       +1     
- Partials      488      489       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper charles-cooper marked this pull request as ready for review February 18, 2024 19:49
@charles-cooper charles-cooper merged commit 4177314 into vyperlang:master Feb 19, 2024
84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants