fix: prevent range over decimal #3798
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3798 +/- ##
==========================================
- Coverage 85.00% 84.99% -0.01%
==========================================
Files 92 92
Lines 13765 13771 +6
Branches 3083 3084 +1
==========================================
+ Hits 11701 11705 +4
- Misses 1575 1576 +1
- Partials 489 490 +1 ☔ View full report in Codecov by Sentry. |
vyper/semantics/analysis/local.py
Outdated
| @@ -512,6 +513,10 @@ def visit_For(self, node): | |||
|
|
|||
| iter_var = None | |||
| if isinstance(node.iter, vy_ast.Call): | |||
| if not isinstance(target_type, IntegerT): | |||
| raise TypeCheckFailure( | |||
There was a problem hiding this comment.
i'd prefer to reuse the exception handling / error message from validate_expected_type
There was a problem hiding this comment.
we should also raise TypeMismatch (a regular exception) rather than a TypeCheckFailure (which is a panic)
hm yea the naming is confusing, we should really rename TypeCheckFailure to TypeCheckPanic
There was a problem hiding this comment.
Replaced TypeCheckFailure by TypeMismatch and now use validate_expected_type
What I did
looping over a
rangewas allowed if the iterator type wasdecimal, this PR prevents this unintended behaviour.How I did it
IntegerT.range()expression are not onlyNumbutInt.How to verify it
See tests
Commit message
Description for the changelog
Cute Animal Picture