Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add prefix to ERC interfaces #3804

Merged
merged 5 commits into from
Feb 24, 2024

Conversation

tserg
Copy link
Collaborator

@tserg tserg commented Feb 23, 2024

What I did

Add I (capital i) prefix to ERC interfaces.

How I did it

How to verify it

Commit message

chore: add prefix to ERC interfaces

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.79%. Comparing base (977ad79) to head (04e5da6).

❗ Current head 04e5da6 differs from pull request most recent head df9320c. Consider uploading reports for the commit df9320c to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3804       +/-   ##
===========================================
- Coverage   85.03%   58.79%   -26.24%     
===========================================
  Files          92       92               
  Lines       13769    13769               
  Branches     3083     3083               
===========================================
- Hits        11708     8096     -3612     
- Misses       1572     4995     +3423     
- Partials      489      678      +189     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@charles-cooper charles-cooper merged commit f97f4eb into vyperlang:master Feb 24, 2024
84 checks passed
@tserg tserg deleted the chore/rename_interfaces branch February 25, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants