fix: mutability check for interface implements #3805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trocher
reviewed
Feb 23, 2024
vyper/semantics/types/function.py
Outdated
Comment on lines
483
to
488
| if self.mutability > other.mutability: | ||
| return False | ||
|
|
||
| if other.is_payable and not self.is_payable: | ||
| return False | ||
|
|
There was a problem hiding this comment.
Suggested change
| if self.mutability > other.mutability: | |
| return False | |
| if other.is_payable and not self.is_payable: | |
| return False | |
| if self.mutability != other.mutability: | |
| return False |
I think we should go all the way and enforce an exact matching of mutabilities: #3774 (comment)
There was a problem hiding this comment.
at this point, just return self.mutability == other.mutability
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3805 +/- ##
==========================================
- Coverage 85.06% 85.05% -0.01%
==========================================
Files 92 92
Lines 13769 13767 -2
Branches 3083 3082 -1
==========================================
- Hits 11712 11710 -2
Misses 1568 1568
Partials 489 489 ☔ View full report in Codecov by Sentry. |
charles-cooper
approved these changes
Feb 25, 2024
charles-cooper
changed the title
payable decorator for interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fix #3774
How I did it
Add a check for
payable.How to verify it
Commit message
Description for the changelog
Cute Animal Picture