-
-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: mutability check for interface implements #3805
Conversation
vyper/semantics/types/function.py
Outdated
if self.mutability > other.mutability: | ||
return False | ||
|
||
if other.is_payable and not self.is_payable: | ||
return False | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if self.mutability > other.mutability: | |
return False | |
if other.is_payable and not self.is_payable: | |
return False | |
if self.mutability != other.mutability: | |
return False |
I think we should go all the way and enforce an exact matching of mutabilities: #3774 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at this point, just return self.mutability == other.mutability
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3805 +/- ##
==========================================
- Coverage 85.06% 85.05% -0.01%
==========================================
Files 92 92
Lines 13769 13767 -2
Branches 3083 3082 -1
==========================================
- Hits 11712 11710 -2
Misses 1568 1568
Partials 489 489 ☔ View full report in Codecov by Sentry. |
payable
decorator for interface
What I did
Fix #3774
How I did it
Add a check for
payable
.How to verify it
Commit message
Description for the changelog
Cute Animal Picture