feat[tool]: validate AST nodes early in the pipeline #3809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
validate Vyper AST nodes as early as possible in the compilation pipeline, during `parse_to_ast()`. this will make compilation fail earlier in the pipeline for integrators which use the result of `-f ast` but don't grab `-f annotated_ast`.
charles-cooper
requested review from
fubuloubu,
harkal,
tserg and
cyberthirst
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3809 +/- ##
========================================
Coverage 85.02% 85.03%
========================================
Files 92 92
Lines 13767 13871 +104
Branches 3082 3112 +30
========================================
+ Hits 11706 11795 +89
- Misses 1572 1581 +9
- Partials 489 495 +6 ☔ View full report in Codecov by Sentry. |
tserg
approved these changes
Feb 26, 2024
pcaversaccio
approved these changes
Feb 26, 2024
charles-cooper
changed the title
fubuloubu
approved these changes
Feb 27, 2024
cyberthirst
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
validate Vyper AST nodes as early as possible in the compilation pipeline, during
parse_to_ast(). this will make compilation fail earlier in the pipeline for integrators which use the result of-f astbut don't grab-f annotated_ast.What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture