fix[codegen]: range bound check for signed integers

[DanielSchiavini]

What I did

• Fixed range overflow when using signed integers

How I did it

• By checking if the target type is signed

How to verify it

• Tests included

Commit message

Fix range overflow when using signed integers

Description for the changelog

Fix range overflow when using signed integers

Cute Animal Picture

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.22%. Comparing base (730679b) to head (b6f87d4).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3814      +/-   ##
==========================================
+ Coverage   85.19%   85.22%   +0.03%     
==========================================
  Files          92       92              
  Lines       13914    13916       +2     
  Branches     3118     3118              
==========================================
+ Hits        11854    11860       +6     
+ Misses       1565     1561       -4     
  Partials      495      495              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[charles-cooper]

haha, we used to have dedicated clample instructions in the IR before i removed them (they did something slightly different than here though).

i think a bit longer-term the right refactor here is to have dedicated helper functions like def LE(is_signed), def GT(is_signed): etc. but it's probably out of scope for this PR.

@DanielSchiavini could you merge in the CI fixes from master? and then i can merge