Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[ux]: improve error message for importing ERC20 #3816

Merged
merged 3 commits into from
Feb 26, 2024

Conversation

charles-cooper
Copy link
Member

improve error message for common issue when upgrading from v0.3.x

What I did

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

improve error message for common issue when upgrading from v0.3.x
@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 85.09%. Comparing base (b53a020) to head (8a6f844).

Files Patch % Lines
vyper/semantics/analysis/module.py 0.00% 8 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3816      +/-   ##
==========================================
- Coverage   85.15%   85.09%   -0.07%     
==========================================
  Files          92       92              
  Lines       13907    13907              
  Branches     3116     3116              
==========================================
- Hits        11843    11834       -9     
- Misses       1571     1581      +10     
+ Partials      493      492       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper charles-cooper enabled auto-merge (squash) February 26, 2024 19:14
@charles-cooper charles-cooper merged commit 6fb750a into vyperlang:master Feb 26, 2024
84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants