-
-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat[ir]: add make_ssa
pass to venom pipeline
#3825
Merged
charles-cooper
merged 354 commits into
vyperlang:master
from
harkal:feature/venom_updates
Apr 2, 2024
Merged
feat[ir]: add make_ssa
pass to venom pipeline
#3825
charles-cooper
merged 354 commits into
vyperlang:master
from
harkal:feature/venom_updates
Apr 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a3ba760.
code, output_formats=["bytecode_runtime"], settings=Settings(optimize=optimize) | ||
code, | ||
output_formats=["bytecode_runtime"], | ||
settings=Settings(optimize=optimize, experimental_codegen=experimental_codegen), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this maybe be like get_settings
or a compile_code
fixture?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can resolve later
…feature/venom_updates
…feature/venom_updates
charles-cooper
approved these changes
Apr 2, 2024
electriclilies
pushed a commit
to electriclilies/vyper
that referenced
this pull request
Apr 27, 2024
this commit updates the venom pipeline to be capable of translating 100% of the original vyper IR, and successfully passes the entire test suite. to accomplish this, the translation pass from the old IR to Venom is simplified, moving several optimization and analysis steps to separate passes. the most significant of these is the `make_ssa` pass, which converts any Venom code into SSA form, therefore letting us write non-SSA code in the translation pass, simplifying the translation. to support the `make_ssa` pass, this commit also adds a dominator tree implementation, along with implementations of dominance frontier and other utility functions. these should also be useful for additional passes that will be contributed in the future. to facilitate the development process, this commit also adds two more output formats: `cfg` and `cfg_runtime`, which provide a graph representation of the Venom code. --------- Co-authored-by: Charles Cooper <cooper.charles.m@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture