Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore[ci]: pin eth-abi for decode regression #3834

Merged

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Mar 5, 2024

eth-abi 5.0.1 introduces a regression for eth-abi decoding due to the way that eth-tester enforces decoding of revert strings.

What I did

fix CI failures, see for instance https://github.com/vyperlang/vyper/actions/runs/8153520136/job/22285100813?pr=3833#step:5:1331

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

eth-abi 5.0.1 introduces a regression for eth-abi decoding due to the
way that eth-tester enforces decoding of revert strings.
@charles-cooper charles-cooper merged commit 8d34e74 into vyperlang:master Mar 5, 2024
84 checks passed
@charles-cooper charles-cooper deleted the chore/eth-abi-regression branch March 5, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants