-
-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor[test]: bypass eth-tester
and interface with evm backend directly
#3846
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3846 +/- ##
==========================================
- Coverage 90.81% 88.63% -2.18%
==========================================
Files 98 98
Lines 14867 14866 -1
Branches 3309 3310 +1
==========================================
- Hits 13501 13177 -324
- Misses 945 1210 +265
- Partials 421 479 +58 ☔ View full report in Codecov by Sentry. |
tests/functional/codegen/calling_convention/test_default_function.py
Outdated
Show resolved
Hide resolved
tests/functional/codegen/environment_variables/test_block_number.py
Outdated
Show resolved
Hide resolved
tests/functional/examples/market_maker/test_on_chain_market_maker.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
incredible. thank you!!!
eth-tester
and interface with evm backend directly
note: this brings average test time from ~14mins to 3-7mins. and i think it opens up a lot of low-hanging fruit to improve CI performance too! |
Depends on #3904 paradigmxyz/pyrevm#13 paradigmxyz/pyrevm#16What I did
Refactor the test suite to use evm backend directly. Got rid of eth-tester and added support for pyrevm.
How I did it
How to verify it
Tests should pass
Commit message
Description for the changelog
N/A
Cute Animal Picture