Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[ir]: unique symbol name #3848

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

trocher
Copy link
Contributor

@trocher trocher commented Mar 8, 2024

What I did

STORE() unique symbol name is computed as _freshname(_freshname(f"{op}_")) instead of _freshname(f"{op}_") after #3835. This PR fixes this.

How I did it

Straightforward

How to verify it

Compiling a contract with a single SSTORE will lead to an IR containing [unique_symbol, sstore_1] where it would previously contain [unique_symbol, sstore_12].

Commit message

fix: unique symbol name

Description for the changelog

Fix unique symbol name

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@charles-cooper charles-cooper changed the title fix[ir]: unique symbol name fix[ir]: STORE unique symbol name Mar 8, 2024
@charles-cooper charles-cooper changed the title fix[ir]: STORE unique symbol name fix[ir]: unique symbol name Mar 8, 2024
@charles-cooper charles-cooper enabled auto-merge (squash) March 8, 2024 18:15
@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.93%. Comparing base (787c562) to head (31d5465).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3848      +/-   ##
==========================================
- Coverage   86.15%   85.93%   -0.22%     
==========================================
  Files          92       92              
  Lines       13921    13921              
  Branches     3067     3067              
==========================================
- Hits        11993    11963      -30     
- Misses       1491     1520      +29     
- Partials      437      438       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper
Copy link
Member

thanks!

@charles-cooper charles-cooper merged commit 7a083d3 into vyperlang:master Mar 8, 2024
83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants