feat[ir]: emit djump in dense selector table
#3849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3849 +/- ##
==========================================
- Coverage 86.15% 86.12% -0.03%
==========================================
Files 92 92
Lines 13921 13923 +2
Branches 3067 3068 +1
==========================================
- Hits 11993 11991 -2
- Misses 1491 1495 +4
Partials 437 437 ☔ View full report in Codecov by Sentry. |
charles-cooper
changed the title
djump instructiondjump in dense selector table
charles-cooper
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
lgtm. @cyberthirst could you take a look at this? @trocher too (time permitting)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Updated the dense selector (used in optimization for codesize) to emit the target constrained
djumpinstruction.How I did it
Made a list of the possible targets and emitted the
djumpinstruction with that.How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture