-
-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix[codegen]: fix transient codegen for slice
and extract32
#3874
Merged
charles-cooper
merged 20 commits into
vyperlang:master
from
cyberthirst:fix/builtins-tstorage-codegen
Apr 4, 2024
Merged
fix[codegen]: fix transient codegen for slice
and extract32
#3874
charles-cooper
merged 20 commits into
vyperlang:master
from
cyberthirst:fix/builtins-tstorage-codegen
Apr 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3874 +/- ##
==========================================
- Coverage 90.91% 90.79% -0.12%
==========================================
Files 95 95
Lines 14401 14411 +10
Branches 3186 3189 +3
==========================================
- Hits 13093 13085 -8
- Misses 908 924 +16
- Partials 400 402 +2 ☔ View full report in Codecov by Sentry. |
slice
and extract32
charles-cooper
approved these changes
Apr 4, 2024
electriclilies
pushed a commit
to electriclilies/vyper
that referenced
this pull request
Apr 27, 2024
…rlang#3874) this commit fixes transient storage codegen for `slice()` and `extract32()` builtins. previously, some codegen routines were hardcoded to check for storage; this commit changes them to check if they are `word_addressable` instead. this commit also refactors the `extract32()` code generation logic to be simpler and use more recent APIs. the new implementation relies on the optimizer to do some optimizations which in this routine were previously hand-rolled. --------- Co-authored-by: Charles Cooper <cooper.charles.m@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
extract32()
andslice()
#3801How I did it
word_addressable
and the usage of generic load opsHow to verify it
Commit message
Description for the changelog
Cute Animal Picture