Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore[build]: remove docs rule in setup.py #3882

Merged

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Mar 23, 2024

What I did

How I did it

How to verify it

Commit message

it is not used, and it conflicts with the requirements specified in
`docs-requirements.txt` (which is _actually_ used, in
`.readthedocs.yaml`).

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

it is not used, and it conflicts with the requirements specified in
`docs-requirements.txt` (which is actually used, in
(./.readthedocs.yaml)).
@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.35%. Comparing base (e589278) to head (f4dfd10).
Report is 4 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3882      +/-   ##
==========================================
+ Coverage   86.33%   86.35%   +0.01%     
==========================================
  Files          92       92              
  Lines       14010    14024      +14     
  Branches     3077     3081       +4     
==========================================
+ Hits        12096    12110      +14     
  Misses       1484     1484              
  Partials      430      430              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper charles-cooper changed the title chore: remove docs rule in setup.py chore[build]: remove docs rule in setup.py Mar 23, 2024
@charles-cooper charles-cooper changed the title chore[build]: remove docs rule in setup.py chore[build]: remove docs rule in setup.py Mar 23, 2024
@charles-cooper charles-cooper enabled auto-merge (squash) March 23, 2024 11:29
@charles-cooper charles-cooper merged commit fd49ead into vyperlang:master Mar 23, 2024
146 checks passed
electriclilies pushed a commit to electriclilies/vyper that referenced this pull request Apr 27, 2024
it is not used, and it conflicts with the requirements specified in
`docs-requirements.txt` (which is _actually_ used, in
`.readthedocs.yaml`).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants