fix[ux]: fix compiler hang for large exponentiations #3893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit fixes a UX bug where the compiler would hang while trying to constant-fold large exponentiations. it does a loose check to see if the output would be fastly out of bounds and fails fast if so.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3893 +/- ##
==========================================
- Coverage 86.36% 85.85% -0.51%
==========================================
Files 92 92
Lines 14025 14028 +3
Branches 3082 3083 +1
==========================================
- Hits 12112 12044 -68
- Misses 1485 1543 +58
- Partials 428 441 +13 ☔ View full report in Codecov by Sentry. |
fubuloubu
approved these changes
Mar 26, 2024
harkal
approved these changes
Mar 26, 2024
electriclilies
pushed a commit
to electriclilies/vyper
that referenced
this pull request
Apr 27, 2024
this commit fixes a UX bug where the compiler would hang while trying to constant-fold large exponentiations. it does a loose check to see if the output would be vastly out of bounds and fails fast if so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit fixes a UX bug where the compiler would hang while trying to constant-fold large exponentiations. it does a loose check to see if the output would be vastly out of bounds and fails fast if so.
What I did
fixes #1667
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture