Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor[venom]: use venom pass instances #3908

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

harkal
Copy link
Collaborator

@harkal harkal commented Apr 3, 2024

What I did

I made the pass "manager" to work with instances instead of classes

How I did it

Updated tha pass handling code, the pass usage code, and the related tests.

How to verify it

Commit message

future venom passes that are currently under development require that
the pass manager works with pass instances rather than classes. this is
a common change that should be merged upstream in order to carry around
less changes to future pull requests.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@harkal harkal changed the title Fix/use pass instances [fix](venom) use venom pass instances Apr 3, 2024
@harkal harkal changed the title [fix](venom) use venom pass instances fix[venom] use venom pass instances Apr 3, 2024
@harkal harkal changed the title fix[venom] use venom pass instances refactor[venom] use venom pass instances Apr 3, 2024
@harkal harkal changed the title refactor[venom] use venom pass instances refactor[venom]: use venom pass instances Apr 3, 2024
@harkal harkal marked this pull request as ready for review April 3, 2024 09:52
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 90.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 90.92%. Comparing base (e34ca9c) to head (6fb76e2).

Files Patch % Lines
vyper/venom/passes/base_pass.py 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3908      +/-   ##
==========================================
- Coverage   90.92%   90.92%   -0.01%     
==========================================
  Files          95       95              
  Lines       14387    14386       -1     
  Branches     3186     3185       -1     
==========================================
- Hits        13081    13080       -1     
  Misses        904      904              
  Partials      402      402              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper charles-cooper merged commit 9db9078 into vyperlang:master Apr 3, 2024
149 of 153 checks passed
@harkal harkal deleted the fix/use_pass_instances branch April 3, 2024 12:05
electriclilies pushed a commit to electriclilies/vyper that referenced this pull request Apr 27, 2024
future venom passes that are currently under development require that
the pass manager works with pass instances rather than classes. this is
a common change that should be merged upstream in order to carry around
less changes to future pull requests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants