fix[test]: fix a bad bound in decimal fuzzing #3909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the decimal fuzz test `is_valid` condition was based on an ancient version of decimals which had bounds at -2**127 and 2**127. update the condition to be compatible with the latest version of Decimal. also increase the range of decimals produced by the decimal fuzzing strategy, so that the fuzzer finds overflow issues faster.
harkal
approved these changes
Apr 3, 2024
some OOB things do not get caught until analysis, so run the analyser.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3909 +/- ##
==========================================
- Coverage 90.93% 88.93% -2.01%
==========================================
Files 95 95
Lines 14388 14391 +3
Branches 3186 3186
==========================================
- Hits 13084 12798 -286
- Misses 904 1133 +229
- Partials 400 460 +60 ☔ View full report in Codecov by Sentry. |
electriclilies
pushed a commit
to electriclilies/vyper
that referenced
this pull request
Apr 27, 2024
the decimal fuzz test `is_valid` condition was based on an ancient version of decimals which had bounds at `-2**127` and `2**127`. update the condition to be compatible with the latest version of `decimal`. also increase the range of decimals produced by the decimal fuzzing strategy, so that the fuzzer finds overflow issues faster. an additional issue was found in the fuzz tests, which is that some decimal operations panic with `decimal.InvalidOperation` instead of a proper exception. this is a known bug, see GH vyperlang#2241. this fixes the issue by catching the exception and raising an `OverflowException`. misc/refactor: - refactor several uses of quantize into a utility function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix a fuzz test, fix #2241, improve boundary conditions for some decimal fuzz tests.
What I did
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture