Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[ci]: update pypi release pipeline to use OIDC #3912

Merged
merged 2 commits into from
Apr 6, 2024

Conversation

charles-cooper
Copy link
Member

OIDC is pypi's current recommended best practice (see below). this commit modifies the pypi release pipeline to use the Trusted Publisher mechanism. it has already been configured on the PyPI side.

references:

What I did

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

OIDC is pypi's current recommended best practice (see below). this
commit modifies the pypi release pipeline to use the Trusted
Publisher mechanism. it has already been configured on the PyPI side.

references:
- https://docs.pypi.org/trusted-publishers/
@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.85%. Comparing base (63b8d1d) to head (65afde2).
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3912      +/-   ##
==========================================
- Coverage   90.92%   90.85%   -0.07%     
==========================================
  Files          95       95              
  Lines       14411    14411              
  Branches     3189     3189              
==========================================
- Hits        13103    13093      -10     
- Misses        908      919      +11     
+ Partials      400      399       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.github/workflows/release-pypi.yml Outdated Show resolved Hide resolved
@charles-cooper charles-cooper enabled auto-merge (squash) April 6, 2024 17:12
@charles-cooper charles-cooper merged commit 7485cea into vyperlang:master Apr 6, 2024
148 checks passed
@charles-cooper charles-cooper deleted the feat/pypi-publisher branch April 6, 2024 17:18
@charles-cooper
Copy link
Member Author

electriclilies pushed a commit to electriclilies/vyper that referenced this pull request Apr 27, 2024
OIDC is pypi's current recommended best practice (see below). this
commit modifies the pypi release pipeline to use the Trusted
Publisher mechanism. it has already been configured on the PyPI side.

references:
- https://docs.pypi.org/trusted-publishers/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants