-
-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix[ux]: fix uses
error message
#3926
fix[ux]: fix uses
error message
#3926
Conversation
when a stateless module is accidentally declared as being `used` by a user, the error message is confusing. update the error message to clarify `uses` refers to state being used.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3926 +/- ##
==========================================
- Coverage 90.94% 90.77% -0.17%
==========================================
Files 95 95
Lines 14397 14397
Branches 3191 3191
==========================================
- Hits 13093 13069 -24
- Misses 904 927 +23
- Partials 400 401 +1 ☔ View full report in Codecov by Sentry. |
this is also a bit confusing when # main
import lib1
import lib2
initializes: lib2
initializes: lib1
@external
def foo():
lib2.foo()
lib2.lib1.counter = 1
# lib1
counter: uint256
# lib2
import lib1
counter: uint256
@internal
def foo():
pass
could we warn about unused imports? |
Fwiw, some time ago (~1 year ago lol), I already opened an issue re this #3272. |
when a stateless module is accidentally declared as being `used` by a user, the error message is confusing. update the error message to clarify `uses` refers to state being used.
What I did
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture