Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[lang]: support block.blobbasefee #3945

Merged
merged 10 commits into from
Apr 22, 2024

Conversation

tserg
Copy link
Collaborator

@tserg tserg commented Apr 14, 2024

What I did

Support block.blobbasefee.

How I did it

How to verify it

Commit message

This commit adds access to the `BLOBBASEFEE` opcode via the environment
variable `block.blobbasefee`. The opcode was introduced in EIP-4844.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 89.14%. Comparing base (80708e6) to head (693f628).

Files Patch % Lines
vyper/codegen/expr.py 50.00% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3945      +/-   ##
==========================================
- Coverage   90.86%   89.14%   -1.73%     
==========================================
  Files          95       95              
  Lines       14454    14458       +4     
  Branches     3205     3207       +2     
==========================================
- Hits        13134    12888     -246     
- Misses        912     1107     +195     
- Partials      408      463      +55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tserg tserg changed the title feat: support block.blobbasefee feat[lang]: support block.blobbasefee Apr 14, 2024
@@ -75,6 +75,8 @@
"CHAINID": (0x46, 0, 1, 2),
"SELFBALANCE": (0x47, 0, 1, 5),
"BASEFEE": (0x48, 0, 1, 2),
"BLOBHASH": (0x49, 1, 1, 3),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also support this? i guess it should probably be supported similarly to blockhash

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think we should. I have done some work on it locally but I am still figuring out how to test it. How about moving this to a separate PR so it does not block block.blobbasefee?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, sounds good

@tserg tserg marked this pull request as ready for review April 18, 2024 04:57
vyper/evm/opcodes.py Outdated Show resolved Hide resolved
Copy link

socket-security bot commented Apr 20, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
pypi/eth-abi@5.1.0 environment, filesystem 0 235 kB carver, fselmo, kclowes, ...2 more
pypi/eth-tester@0.11.0b1 environment, filesystem, network 0 465 kB carver, cburgdorf, fselmo, ...5 more
pypi/web3@7.0.0b4 environment, eval, filesystem, network, shell 0 4.61 MB carver, fselmo, kclowes, ...5 more

🚮 Removed packages: pypi/eth-abi@4.2.1, pypi/eth-abi@4.2.1, pypi/eth-tester@0.10.0b4, pypi/eth-tester@0.10.0b4, pypi/web3@6.0.0, pypi/web3@6.0.0

View full report↗︎

Co-authored-by: sudo rm -rf --no-preserve-root / <pcaversaccio@users.noreply.github.com>
@charles-cooper charles-cooper merged commit f6c0c89 into vyperlang:master Apr 22, 2024
148 checks passed
electriclilies pushed a commit to electriclilies/vyper that referenced this pull request Apr 27, 2024
This commit adds access to the `BLOBBASEFEE` opcode via the environment
variable `block.blobbasefee`. The opcode was introduced in EIP-4844.

---------

Co-authored-by: sudo rm -rf --no-preserve-root / <pcaversaccio@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants