-
-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat[lang]: support block.blobbasefee
#3945
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3945 +/- ##
==========================================
- Coverage 90.86% 89.14% -1.73%
==========================================
Files 95 95
Lines 14454 14458 +4
Branches 3205 3207 +2
==========================================
- Hits 13134 12888 -246
- Misses 912 1107 +195
- Partials 408 463 +55 ☔ View full report in Codecov by Sentry. |
block.blobbasefee
block.blobbasefee
vyper/evm/opcodes.py
Outdated
@@ -75,6 +75,8 @@ | |||
"CHAINID": (0x46, 0, 1, 2), | |||
"SELFBALANCE": (0x47, 0, 1, 5), | |||
"BASEFEE": (0x48, 0, 1, 2), | |||
"BLOBHASH": (0x49, 1, 1, 3), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we also support this? i guess it should probably be supported similarly to blockhash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think we should. I have done some work on it locally but I am still figuring out how to test it. How about moving this to a separate PR so it does not block block.blobbasefee
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, sounds good
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: pypi/eth-abi@4.2.1, pypi/eth-abi@4.2.1, pypi/eth-tester@0.10.0b4, pypi/eth-tester@0.10.0b4, pypi/web3@6.0.0, pypi/web3@6.0.0 |
Co-authored-by: sudo rm -rf --no-preserve-root / <pcaversaccio@users.noreply.github.com>
tests/functional/codegen/environment_variables/test_blobbasefee.py
Outdated
Show resolved
Hide resolved
tests/functional/codegen/environment_variables/test_blobbasefee.py
Outdated
Show resolved
Hide resolved
tests/functional/codegen/environment_variables/test_blobbasefee.py
Outdated
Show resolved
Hide resolved
This commit adds access to the `BLOBBASEFEE` opcode via the environment variable `block.blobbasefee`. The opcode was introduced in EIP-4844. --------- Co-authored-by: sudo rm -rf --no-preserve-root / <pcaversaccio@users.noreply.github.com>
What I did
Support
block.blobbasefee
.How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture