-
-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat[lang]: add blobhash()
builtin
#3962
Conversation
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3962 +/- ##
==========================================
+ Coverage 90.82% 90.87% +0.04%
==========================================
Files 98 95 -3
Lines 14867 14464 -403
Branches 3310 3207 -103
==========================================
- Hits 13503 13144 -359
+ Misses 944 912 -32
+ Partials 420 408 -12 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
we should ideally have functional tests, like check that blobhash actually matches what is in the evm |
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
as discussed offline, |
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@@ -4,16 +4,16 @@ | |||
|
|||
import rlp | |||
from cached_property import cached_property | |||
from eth.abc import ChainAPI, ComputationAPI | |||
from eth.abc import ChainAPI, ComputationAPI, VirtualMachineAPI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a nit but i'm not a huge fan of importing things that are only used in type signatures, i am starting to prefer guarding these with if TYPE_CHECKING
blobhash(uint256)
blobhash()
builtin
What I did
Introduce the built-in function
blobhash(uint256)
for retrieving versioned hashes of BLOBs.How I did it
Hard skills.
How to verify it
See https://eips.ethereum.org/EIPS/eip-4844#opcode-to-get-versioned-hashes.
Commit message
Description for the changelog
feat: introduce the built-in function
blobhash(uint256)
for retrieving versioned hashes of BLOBs.Cute Animal Picture