-
-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix[codegen]: fix double evals in sqrt, slice, blueprint #3976
fix[codegen]: fix double evals in sqrt, slice, blueprint #3976
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3976 +/- ##
===========================================
- Coverage 90.97% 51.01% -39.96%
===========================================
Files 106 105 -1
Lines 15288 15267 -21
Branches 3367 3365 -2
===========================================
- Hits 13908 7789 -6119
- Misses 942 6852 +5910
- Partials 438 626 +188 ☔ View full report in Codecov by Sentry. |
What I did
fix for:
sqrt()
argument #3972How I did it
cache respective args
How to verify it
added new tests for side-effect evaluations for the respective builtins
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture