-
-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix[lang]: typecheck hashmap indexes with folding #4007
fix[lang]: typecheck hashmap indexes with folding #4007
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good to me. paging @Leminkay to double check
LGTM! |
@DanielSchiavini update the commit message please with a description of how the change was arrived at, and i'll merge |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4007 +/- ##
===========================================
- Coverage 90.90% 47.96% -42.94%
===========================================
Files 105 105
Lines 15246 15247 +1
Branches 3358 3358
===========================================
- Hits 13859 7313 -6546
- Misses 952 7326 +6374
- Partials 435 608 +173 ☔ View full report in Codecov by Sentry. |
Fixes #3984
What I did
How I did it
How to verify it
Commit message
Description for the changelog
HashMap index is checked when the subscript is folded
Cute Animal Picture