Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore[test]: add macos to test matrix #4025

Merged
merged 16 commits into from
May 15, 2024

Conversation

DanielSchiavini
Copy link
Contributor

@DanielSchiavini DanielSchiavini commented May 15, 2024

What I did

  • Expanded the matrix to include macos and windows tests
  • Removed unnecessary lines from the matrix definition

How I did it

  • All default values must be in the top-level matrix definition
  • The includes section should contain alternative runs - these will not have all default values defined
    • Therefore reading from the matrix requires passing default values again
    • However we can still delete a lot of repetition

How to verify it

  • Tests should pass. We should have 2 extra jobs and the existing ones should keep on existing.

Commit message

- Expanded the matrix to include macos and windows tests
- Refactor the matrix and removed unnecessary lines
- Remove now-redundant windows job

Note that all because of the way github creates matrix jobs, default
values must be in the top-level matrix definition. The includes section
should contain alternative runs - these will not have all default values
defined, therefore reading from the matrix requires passing default
values again.

Description for the changelog

N/A

Cute Animal Picture

image

@DanielSchiavini DanielSchiavini marked this pull request as ready for review May 15, 2024 14:03
This reverts commit 40c6c4a.
@charles-cooper
Copy link
Member

let's put the OS in the front of the job name. we can also drop it in the default case, we only need to distinguish for windows + macos

@charles-cooper charles-cooper changed the title chore[test]: multi-platform test matrix chore[test]: add macos to test matrix May 15, 2024
Copy link
Member

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@charles-cooper charles-cooper merged commit 41a3e08 into vyperlang:master May 15, 2024
155 checks passed
@DanielSchiavini DanielSchiavini deleted the test/windows-pipeline branch May 15, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants