-
-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix[codegen]: fix double eval of start in range expr #4033
fix[codegen]: fix double eval of start in range expr #4033
Conversation
we should have tests for both 1 and 2 argument cases |
also this seems fine, but didn't we just add a fence for |
addressed in: 8b5b364 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4033 +/- ##
===========================================
- Coverage 91.12% 52.70% -38.42%
===========================================
Files 106 106
Lines 15308 15309 +1
Branches 3365 3366 +1
===========================================
- Hits 13949 8069 -5880
- Misses 925 6603 +5678
- Partials 434 637 +203 ☔ View full report in Codecov by Sentry. |
as discussed, it's a question of panicking for certain classes of contracts vs having some perf penalty eg contracts like this wouldn't compile without the cache @internal
@view
def bar() -> uint256:
return 0
@external
def foo():
for i:uint256 in range(self.bar(), 5, bound = 3):
pass |
What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture