fix[codegen]: fix make_setter overlap with internal calls

[charles-cooper]

What I did

fix #3503

How I did it

How to verify it

Commit message

fix overlap analysis for `make_setter` when the RHS contains an internal
call. this represents a bug which was partially fixed in 1c8349e;
this commit fixes two variants:

- where the RHS contains an internal call, the analysis needs to take
  into account all storage variables touched by the called function.

- where the RHS contains an external call, the analysis needs to assume
  any storage variable could be touched (this is a conservative
  analysis; a more advanced analysis could limit the assumption to
  storage variables touched by reentrant functions)

---------

Co-authored-by: cyberthirst <cyberthirst.eth@gmail.com>
Co-authored-by: trocher <rocher14@live.fr>

Description for the changelog

Cute Animal Picture

[cyberthirst]

recursion missing:

def test_make_setter_external_call2(get_contract):
    # variant of GH #3503
    code = """
interface A:
   def boo(): nonpayable

a: DynArray[uint256, 10]

@external
def foo() -> DynArray[uint256, 10]:
    self.a = [1, 2, self.baz(), 4]
    return self.a # returns [11, 12, 3, 4]


@internal
def baz() -> uint256:
    extcall A(self).boo()
    return 3

@external
def boo():
    self.a = [11, 12, 13, 14, 15, 16]
    self.a = []
    # it should now be impossible to read any of [11, 12, 13, 14, 15, 16]
    """
    c = get_contract(code)

    assert c.foo() == [1, 2, 3, 4

>       assert c.foo() == [1, 2, 3, 4]
E       assert [11, 12, 3, 4] == [1, 2, 3, 4]
E         
E         At index 0 diff: 11 != 1
E         Use -v to get more diff

[cyberthirst]

unused?

[charles-cooper]

thanks to @trocher for the test case contributed in 7fc2426