feat[venom]: optimize branching #4049
Merged
+90
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moved the pass one step up so it does not need to delete instructions, they just become unused and the `RemoveUnusedVariablesPass` does the work
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4049 +/- ##
==========================================
- Coverage 91.01% 88.63% -2.39%
==========================================
Files 106 107 +1
Lines 15387 15326 -61
Branches 3384 3369 -15
==========================================
- Hits 14005 13584 -421
- Misses 948 1231 +283
- Partials 434 511 +77 ☔ View full report in Codecov by Sentry. |
use it to optimize branch optimizer
| @@ -22,6 +22,10 @@ def get_uses(self, op: IRVariable) -> list[IRInstruction]: | |||
| def get_producing_instruction(self, op: IRVariable) -> Optional[IRInstruction]: | |||
| return self._dfg_outputs.get(op) | |||
|
|
|||
| def add_use(self, op: IRVariable, inst: IRInstruction): | |||
| uses = self._dfg_inputs.setdefault(op, []) | |||
| uses.append(inst) | |||
There was a problem hiding this comment.
note: this could be out of order from recalculating dfg from scratch, maybe in the future we should use something like set() or OrderedSet() for uses
charles-cooper
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added a pass to optimize inefficient branches
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture