-
-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix[tool]: compile multiple files #4053
fix[tool]: compile multiple files #4053
Conversation
depends on #3789 for the storage layout test updates |
very interesting issue. putting stuff to cache across separate compilation runs seems pretty dangerous. |
none come to mind. it's actually not supposed to cache across compilation runs, assigning |
What I did
fix compilation for multiple files where they initialize the same module. the analysis was getting cached between compilations, leading to a compiler panic on allocating the storage layout (because the module was previously touched by the allocator).
this was not caught in previous testing because the pattern in the test suite is to run a single compilation per test, with a fresh input bundle.
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture