fix[ir]: fix a latent bug in sha3_64 codegen
#4063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit fixes a latent bug in `sha3_64` asm generation, where the second argument to `sha3_64` is generated with the wrong stack height note the bug cannot currently be triggered from vyper source code (hence, it is latent), because there is nowhere in IR generation that the second item is accessed as a witharg. patches GHSA-6845-xw22-ffxv
cyberthirst
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit fixes a latent bug in
sha3_64asm generation, where the second argument tosha3_64is generated with the wrong stack heightnote the bug cannot currently be triggered from vyper source code (hence, it is latent), because there is nowhere in IR generation that the second item is accessed as a witharg.
patches GHSA-6845-xw22-ffxv
What I did
fix #4062
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture