Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[lang]: prevent modules as storage variables #4088

Merged

Conversation

charles-cooper
Copy link
Member

prevent modules being initialized as storage variables.

What I did

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

prevent modules being initialized as storage variables.
@charles-cooper charles-cooper added this to the v0.4.0 milestone Jun 1, 2024
Copy link

codecov bot commented Jun 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.35%. Comparing base (bb9129a) to head (5a0d29d).
Report is 38 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4088      +/-   ##
==========================================
- Coverage   91.24%   90.35%   -0.89%     
==========================================
  Files         109      109              
  Lines       15548    15548              
  Branches     3416     3416              
==========================================
- Hits        14186    14048     -138     
- Misses        928     1039     +111     
- Partials      434      461      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper charles-cooper merged commit d9f10d7 into vyperlang:master Jun 2, 2024
156 of 157 checks passed
@charles-cooper charles-cooper deleted the fix/module-initialization branch June 2, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants