feat[lang]: rename _abi_encode and _abi_decode

[charles-cooper]

What I did

How I did it

How to verify it

Commit message

rename to `abi_encode` and `abi_decode` respectively
leave the old ones in, but with deprecation warnings

Description for the changelog

Cute Animal Picture

[z80dev]

🔥

[cyberthirst]

are we abandoning the idea of using abi.encode / abi.decode?

[cyberthirst]

i think we can update the docs too in this PR

[cyberthirst]

would like to see at least a few tests for the new variant

[cyberthirst]

do we need to display this to the users?

vyper_warn(f"`{self._id}()` is deprecated! Please use `{super()._id}()` instead.", node)

from:

UserWarning: `_abi_decode()` is deprecated! Please use `abi_decode()` instead.

  contract "tests/custom/test4.vy:4", function "run", line 4:52 
       3     y: Bytes[2 * 32 + 3 * 32 + 3 * 32 * 4] = x
  ---> 4     decoded_y1: DynArray[DynArray[uint256, 3], 3] = _abi_decode(
  -----------------------------------------------------------^
       5         y,

  vyper_warn(f"`{self._id}()` is deprecated! Please use `{super()._id}()` instead.", node)

[cyberthirst]

nit:

vyper/vyper/builtins/functions.py

Lines 2338 to 2339 in 7ccd951

	# e.g. _abi_encode(bytes) -> _abi_encode((bytes,))
	# _abi_encode((bytes,)) -> _abi_encode(((bytes,),))

[cyberthirst]

this won't be problematic?

vyper/vyper/ast/grammar.lark

Line 300 in 24cfe0b

abi_decode: "_abi_decode" "(" arg "," type ( "," kwarg )* ")"

[pcaversaccio]

Please also fix the docs and add a note in the docs for _abi_encode and _abi_decode. Something like:

The syntax `_abi_encode` has been deprecated from version 0.4.0 onwards. Please use `_abi_encode` operator instead.

The syntax `_abi_decode` has been deprecated from version 0.4.0 onwards. Please use `abi_decode` operator instead.

[fubuloubu]

are we abandoning the idea of using abi.encode / abi.decode?

would love to have abi module namespaced under ethereum stdlib module

[charles-cooper]

do we need to display this to the users?

vyper_warn(f"`{self._id}()` is deprecated! Please use `{super()._id}()` instead.", node)

i think that's just a function of how warnings.warn() works, we can investigate how to squash them but it's unrelated to this PR

[charles-cooper]

this won't be problematic?

vyper/vyper/ast/grammar.lark

Line 300 in 24cfe0b

abi_decode: "_abi_decode" "(" arg "," type ( "," kwarg )* ")"

hmm yea, it will make some tests fail once we update the usages in the test suite

[charles-cooper]

are we abandoning the idea of using abi.encode / abi.decode?

yea, at least for now. it's a less trivial change, we have no machinery for it right now