-
-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix[lang]: use folded node for typechecking #4365
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4365 +/- ##
==========================================
- Coverage 90.99% 88.81% -2.18%
==========================================
Files 112 112
Lines 16017 16018 +1
Branches 2696 2696
==========================================
- Hits 14574 14226 -348
- Misses 1005 1281 +276
- Partials 438 511 +73 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add another test for conversion of invalid bytestrings
Co-authored-by: Charles Cooper <cooper.charles.m@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. @cyberthirst is there anything you want to see here?
What I did
Fix #4190, #4360.
How I did it
Use the reduced node for typechecking.
How to verify it
See added tests
Commit message
Description for the changelog
Fix compilation for valid syntax with foldable values
Cute Animal Picture