Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore[docs]: nonpayable internal function behaviour #4416

Merged

Conversation

pcaversaccio
Copy link
Collaborator

@pcaversaccio pcaversaccio commented Dec 20, 2024

What I did

Resolves #37584of Attackathon | Ethereum Protocol. Add a note to clarify that nonpayable internal functions can be called via external payable functions.

How I did it

Brain.

How to verify it

Skills.

Commit message

this commit adds a note to clarify that `nonpayable` `internal`
functions can be called via `external` `payable` functions.

Description for the changelog

Add a note to clarify that nonpayable internal functions can be called via external payable functions.

Cute Animal Picture

image

Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@pcaversaccio pcaversaccio self-assigned this Dec 20, 2024
@pcaversaccio pcaversaccio added the documentation Documentation label Dec 20, 2024
@pcaversaccio pcaversaccio changed the title chore[docs]: nonpayable internal functions can be called via external payable functions chore[docs]: nonpayable internal function behaviour Dec 20, 2024
@cyberthirst
Copy link
Collaborator

can you please define in the docs what is means that an internal function is payable? ie that the semantics are whether it can/cannot touch msg.value

Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@pcaversaccio
Copy link
Collaborator Author

can you please define in the docs what is means that an internal function is payable? ie that the semantics are whether it can/cannot touch msg.value

bb40500

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.46%. Comparing base (eee31e7) to head (bb40500).
Report is 12 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (eee31e7) and HEAD (bb40500). Click for more details.

HEAD has 121 uploads less than BASE
Flag BASE (eee31e7) HEAD (bb40500)
140 19
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4416       +/-   ##
===========================================
- Coverage   91.68%   51.46%   -40.23%     
===========================================
  Files         116      119        +3     
  Lines       16481    16615      +134     
  Branches     2778     2794       +16     
===========================================
- Hits        15111     8551     -6560     
- Misses        939     7436     +6497     
- Partials      431      628      +197     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper charles-cooper merged commit da5beb6 into vyperlang:master Dec 31, 2024
158 of 159 checks passed
@pcaversaccio pcaversaccio deleted the docs/payable-internal-functions branch December 31, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants