Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage list logging #571

Merged
merged 6 commits into from
Dec 14, 2017

Conversation

jacqueswww
Copy link
Contributor

@jacqueswww jacqueswww commented Dec 11, 2017

- What I did

Fixes #551.

  • Adds support for logging lists from storage.
  • Adds support for logging lists from storage.
  • Tests.

- How I did it

See pack_args_by_32.

- How to verify it

See #551.

Bar: __log__({_value: num[4]})
x: num[4]

@public
def foo():
    log.Bar(self.x)

@public
def set_list():
    self.x = [1, 2, 3, 4]
MyLog: __log__({arg1: bytes <= 29})
x:bytes<=5

@public
def foo(a:num):
    log.MyLog(self.x)

@public
def setbytez():
    self.x = 'hello'

@public
def getbytes() -> bytes <=29:
    return self.x

- Description for the changelog

- Cute Animal Picture

@fubuloubu
Copy link
Member

Testing looks good to me

@DavidKnott
Copy link
Contributor

@jacqueswww Could add test logging a list of a different type?

@jacqueswww
Copy link
Contributor Author

@DavidKnott sure thing will do.

@jacqueswww
Copy link
Contributor Author

@DavidKnott done :)

@DavidKnott
Copy link
Contributor

@jacqueswww Thanks, LGTM

@DavidKnott DavidKnott merged commit 8f12e6c into vyperlang:master Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants