Use eth-tester. #815

pipermerriam · 2018-05-10T16:15:42Z

Let's do this!

pipermerriam · 2018-05-10T16:16:36Z

tests/conftest.py

+        if get_key(value) in values_to_remove:
+            continue
+        self.queue.put_nowait(value)
+eth_tester.utils.filters.Filter.remove = Filter_remove


This looks like a good case for using the monkeypatch fixture that pytest provides assuming you are not aware of it.

wasn't aware thanks ;)

pipermerriam · 2018-05-10T16:20:40Z

tests/conftest.py

-        return chain.contract(source_code, language="vyper", *args, **kwargs)
-    return get_contract
+def assert_tx_failed(tester):
+    def assert_tx_failed(function_to_test, exception=TransactionFailed):


These would be pretty easy to implement using contextlib.contextmanager if you wanted to niceness of pytest.raises(...)

@contextlib.contextmanager def tx_fails(exception=...): try: yield except exception: pass else: raise AssertionError("Did not raise")

pipermerriam · 2018-05-10T16:21:44Z

tests/conftest.py

+def get_logs(w3):
+    def get_logs(tx_hash, c, event_name):
+        tx_receipt = w3.eth.getTransactionReceipt(tx_hash)
+        logs = getattr(c._classic_contract.events, event_name)().processReceipt(tx_receipt)


latest web3 now supports c._classic_contract.events[event_name]

pipermerriam · 2018-05-10T16:23:49Z

tests/examples/auctions/test_simple_open_auction.py

    # Check bidding time is 5 days
-    assert auction_tester.c.auction_end() == auction_tester.s.head_state.timestamp + 432000
+    assert auction_contract.auction_end() == tester.backend.chain.header.timestamp + EXPIRY - 1


if you want to be future proof, I'd recommend changing this to not reach into the backend and to instead use tester.get_block_by_number['latest']['timestamp']. In fact, now that I've seen this, I'm inclined to rename the location of backend to tester._backend so that it's clear that it's a private API.

pipermerriam · 2018-05-10T16:26:50Z

tests/conftest.py

+        }
+        tx = w3.eth.sendTransaction(deploy_transaction)
+        address = w3.eth.getTransactionReceipt(tx)['contractAddress']
+        contract = w3.eth.contract(address, abi=abi, bytecode=bytecode, ContractFactoryClass=ConciseContract)


I see you are using ConciseContract copiously. My first inclination was to push you away from it, but I think that's mostly my personal preference speaking.

Was the choice to use this happenstance? Intentional over the more explicit call semantics for the default Contract class?

@pipermerriam the biggest reason for the vyper use case is to be able to call functions directly on the contract object.
For vyper easily 95% or more of the tests, you want to call a function and get it's output. That's why opted to just keep get_contract the same as before.

pipermerriam · 2018-05-10T16:35:40Z

tests/parser/features/test_assert.py



-def test_assert_refund(t, get_contract_with_gas_estimation):
+def test_assert_refund(w3, tester, get_contract_with_gas_estimation, assert_tx_failed):


Curious of the choice to use both w3 and tester here. w3.eth.getBalance(...) should allow you to avoid direct tester interactions which is mostly just academic, but it does reduce how closely your API is tied to the eth-tester API (and the w3 API is likely to be more stable).

I agree, for tests direct tester acces should be minimised, and w3 and fixtures maximised will change accordingly ;)

pipermerriam · 2018-05-10T16:37:09Z

tests/parser/features/test_gas.py

-    assert c.foo(startgas=50000) > 25000
+    assert c.foo(call={"gas": 50000}) < 50000
+    assert c.foo(call={"gas": 50000}) > 25000
+
    print('Passed gas test')


total nitpick on my part, but converting these print statements to use logging allows you to get the same output in your terminal while still allowing that output to be easily silenced, or even tuned to only show a subset by logger or by log level.

pipermerriam · 2018-05-10T16:40:40Z

tests/parser/functions/test_block_number.py

-def test_block_number(get_contract_with_gas_estimation, chain):
-    chain.mine(1)
+def test_block_number(get_contract_with_gas_estimation, tester):
+    tester.mine_blocks(1)


Just in case you aren't aware, w3.testing.mine(n) can be used if you want to stick with web3 APIs

neat, I didn't know. Yes I think having tests use web3 as much as possible is the way to go.

pipermerriam · 2018-05-10T16:41:34Z

tests/parser/functions/test_sha3.py


-    assert c.bar() == utils.sha3("inp")
+    assert '0x' + c.bar().hex() == sha3(b"inp").hex()


Reduces readability on the assert statement but you could drop the hex overhead and do the direct assertion.

pipermerriam · 2018-05-10T16:42:11Z

tests/conftest.py

+
+
+@pytest.fixture
+def sha3():


I'd recommend renaming this to keccak. (which makes me realize we should deprecate Web3.sha3 and rename it to keccak as well.

pipermerriam · 2018-05-11T19:13:40Z

tests/examples/wallet/test_wallet.py

+            w3.toInt(x[64:]),  # v
+            w3.toInt(x[:32]),  # r
+            w3.toInt(x[32:64])  # s
+        ) for x in map(lambda z: w3.toBytes(hexstr=z[2:]), raw_sigs)


The [2:] is no longer necessary here. Same with all other calls with a hexstr=thing[2:]

pipermerriam · 2018-05-11T19:14:19Z

tests/examples/wallet/test_wallet.py

    # Check to make sure the signatures are valid
-    assert '0x' + utils.encode_hex(utils.sha3(utils.ecrecover_to_pub(h2, sigs[0][0], sigs[0][1], sigs[0][2]))[12:]) == accounts[0]
-    assert '0x' + utils.encode_hex(utils.sha3(utils.ecrecover_to_pub(h2, sigs[1][0], sigs[1][1], sigs[1][2]))[12:]) == accounts[1]
+    assert Account.recoverHash(h2, sigs[0]).lower() == accounts[0]


If you want, you can use eth_utils.is_same_address which handles equality for addresses across checksum, normal hex, and bytes representations.

pipermerriam · 2018-05-11T19:15:24Z

tests/examples/wallet/test_wallet.py

@@ -1,73 +1,106 @@
 import pytest

+from eth_keys import KeyAPI


You can also use from eth_keys import keys and remove anywhere that you are doing keys = KeysAPI()

fubuloubu · 2018-05-12T13:43:03Z

This PR proves the need for an opinionated testing library for python, something you can just import and know that there is always one preferred way of doing something for testing.

fubuloubu · 2018-05-16T19:42:11Z

Woo!

jacqueswww added 12 commits April 6, 2018 15:46

Patch get_contract and get_contract_from_lll to use web3 + eth_tester.

ab26da5

Add tester fixture.

3bd918e

Zero pad array after slicing.

d367177

Use fixed168x10 instead of decimal10 for the abi notation.

15b678d

Convert more tests to use eth-tester.

170c66e

Fixes company.v.py tests to use eth-tester.

bd3fba2

Converts vypercoin example tests to use eth-tester.

c6d1935

Convert more tests to use eth-tester.

47ad231

Convert more tests to use eth-tester.

79c90a4

Fix is_contract to return either 0x0 or 0x1 on the byte level.

746c404

Move zero padding to return statement instead of the slice function.

7b01b6b

Convert more tests to use eth-tester.

d570441

pipermerriam commented May 10, 2018

View reviewed changes

carver mentioned this pull request May 10, 2018

Planned v5 changes ethereum/web3.py#722

Closed

22 tasks

Fixes ecrecover tests to use eth_tester.

fab39d9

pipermerriam commented May 11, 2018

View reviewed changes

jacqueswww added 7 commits May 15, 2018 00:11

Fix zero padding for returning bytes in log statements.

b1b576e

Fix rlpdecoder tests.

575f8e0

Fix test_rawcall.

b366459

Merge branch 'master' into eth_tester

099eb2b

Fix zero_pad_i allocation on log statement data.

c15f7e8

Use monkeypatch for patching.

2def2db

Clean up tests a bit.

dff29db

jacqueswww changed the title ~~For Jacques~~ Use eth-tester. May 15, 2018

PEP8 Fixes

f78a259

jacqueswww force-pushed the eth_tester branch 2 times, most recently from 4694891 to c4c8f0f Compare May 16, 2018 15:05

Merge master.

72e36c0

jacqueswww force-pushed the eth_tester branch from c4c8f0f to 72e36c0 Compare May 16, 2018 15:12

jacqueswww added 4 commits May 16, 2018 17:14

Merge branch 'master' into eth_tester

de0f2fc

Fix indentation.

bcd66f2

Remove pyethereum compiler dummy object.

077c72a

Fixes gas-estimation to use eth-tester.

236f9fe

jacqueswww merged commit 248c723 into vyperlang:master May 17, 2018

mattermat mentioned this pull request Jun 1, 2018

Vypercoin testing fails #860

Closed

dylanjw mentioned this pull request Aug 7, 2018

Vyper decimal10 abi type support ethereum/web3.py#700

Closed

axic mentioned this pull request May 5, 2020

Document Vyper's decimal10 type in the ABI ethereum/solidity#3869

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use eth-tester. #815

Use eth-tester. #815

pipermerriam commented May 10, 2018 •

edited by jacqueswww

Loading

pipermerriam May 10, 2018

jacqueswww May 15, 2018

pipermerriam May 10, 2018

pipermerriam May 10, 2018

pipermerriam May 10, 2018

pipermerriam May 10, 2018

jacqueswww May 10, 2018 •

edited

Loading

pipermerriam May 10, 2018

jacqueswww May 11, 2018 •

edited

Loading

pipermerriam May 10, 2018

pipermerriam May 10, 2018

jacqueswww May 10, 2018 •

edited

Loading

pipermerriam May 10, 2018

pipermerriam May 10, 2018

pipermerriam May 11, 2018

pipermerriam May 11, 2018

pipermerriam May 11, 2018

fubuloubu commented May 12, 2018

fubuloubu commented May 16, 2018



		def test_assert_refund(t, get_contract_with_gas_estimation):
		def test_assert_refund(w3, tester, get_contract_with_gas_estimation, assert_tx_failed):


		assert c.bar() == utils.sha3("inp")
		assert '0x' + c.bar().hex() == sha3(b"inp").hex()

Use eth-tester. #815

Use eth-tester. #815

Conversation

pipermerriam commented May 10, 2018 • edited by jacqueswww Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jacqueswww May 10, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jacqueswww May 11, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jacqueswww May 10, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fubuloubu commented May 12, 2018

fubuloubu commented May 16, 2018

pipermerriam commented May 10, 2018 •

edited by jacqueswww

Loading

jacqueswww May 10, 2018 •

edited

Loading

jacqueswww May 11, 2018 •

edited

Loading

jacqueswww May 10, 2018 •

edited

Loading