Fixing attempts incrementing:

[mrvtoney]

In the RabbitMQQueue.php:

• $message was changed to a class property ($this->message)

In the RabbitMQJob.php:

• class const ATTEMPT_COUNT_HEADERS_KEY was changed from “attempts_count” to “attempts”

[mrvtoney]

@vyuldashev I can't figure out what errored out for the styleci/pr check. Can you point it out for me?

[vyuldashev]

$message was changed to a class property ($this->message)

I don't think it's a good idea. Why did you add this?

[mrvtoney]

The message was a class property in the RabbitMQJob as well.

However, simply changing the value of the const ATTEMPT_COUNT_HEADERS_KEY did not fix the problem as a whole.

The message's state needed to persist through the process in order to increment. Every time the message was used it was recreated. However, when it was recreated it did not take into consideration or apply the logic for the attempts. Meaning that each time a new message was assembled in pushRaw the was not set.

Debugging the code. I realized that the options array was always empty which prevented attempts from being assigned as a message property.

The body of the message originally holds the attempts. Which is then set in the message property.

[vyuldashev]

I just pushed tests for job attempts. And seems like it works like expected: https://travis-ci.org/vyuldashev/laravel-queue-rabbitmq/jobs/613081677

Also, we are using this library in many application in production which somehow have logic with attempts count and everything works.

[mrvtoney]

That is great to hear.

Yeah. While going through the laravel worker code. I saw that database, redis and sync all utilized attempts.

I modified it in order to maintain consistency with laravel's other queue drivers.

I can change it back and test on my side to see if the change from attempt_counts to attempts.

[mrvtoney]

@vyuldashev I tested and changed 'attempts' back to 'attempts_count'

[vyuldashev]

So why do I need to accept this PR if attempts are incrementing?

[mrvtoney]

Attempts do not increment without the changes to RabbitMQQueue.php.

It fixes this issue:

• Forever retry when job timeout #235

[mrvtoney]

@vyuldashev do you have any other suggestions for my PR?

[vyuldashev]

I will review and test it and probably this goes to v10

[vyuldashev]

I tried your code, seems like it does not fix #235

[mrvtoney]

@vyuldashev Can you send me the steps you used to test so I can test again on my side, please?

[vyuldashev]

@mrvtoney I used the same code from #235
I think I found a solution but it will break BC. So, I need to work on it and it will go to v10