fix: make sure to set span parent

w-h-a · Oct 14, 2024 · d905c1b · d905c1b
1 parent 165437d
commit d905c1b
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 18 deletions.
diff --git a/telemetry/tracev2/memory/trace.go b/telemetry/tracev2/memory/trace.go
@@ -46,7 +46,7 @@ func (t *memoryTrace) Start(ctx context.Context, name string) (context.Context,
 
 	t.spans[key] = span
 
-	newCtx, _ := tracev2.ContextWithSpan(ctx, span.SpanContext().SpanID())
+	newCtx, _ := tracev2.ContextWithSpanParent(ctx, span.SpanContext().SpanID())
 
 	return newCtx, key
 }

diff --git a/telemetry/tracev2/utils.go b/telemetry/tracev2/utils.go
@@ -45,20 +45,3 @@ func SpanParentFromContext(ctx context.Context) (spanparent [8]byte, found bool)
 
 	return
 }
-
-func ContextWithSpan(ctx context.Context, span [8]byte) (context.Context, error) {
-	return metadatautils.MergeContext(ctx, map[string]string{
-		spanKey: string(span[:]),
-	}, true), nil
-}
-
-func SpanFromContext(ctx context.Context) (span [8]byte, found bool) {
-	spanId, found := metadatautils.GetContext(ctx, spanKey)
-	if !found {
-		return
-	}
-
-	copy(span[:], spanId)
-
-	return
-}