Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shared gens section & invalid cryptosuite generator #41

Merged
merged 5 commits into from
Jun 17, 2024

Conversation

aljones15
Copy link
Contributor

Features:

  1. exports issueCloned
  2. Adds a new shared generators section for invalid cryptosuite name tests.

@aljones15 aljones15 self-assigned this Jun 13, 2024
@aljones15 aljones15 changed the title Add shared gens Add shared gens section & invalid cryptosuite generator Jun 14, 2024
@aljones15 aljones15 marked this pull request as ready for review June 14, 2024 15:21
@PatStLouis
Copy link
Collaborator

The goal here is to add a negative test for an invalid cryptosuite?

@aljones15
Copy link
Contributor Author

The goal here is to add a negative test for an invalid cryptosuite?

that is the goal, but this PR only adds a generator so that whenever you need to create a VC signed with an invalid cryptosuite, you can use this generator or this generator combined with other generators (I created a VC with an invalid proof.type and proof.cryptosuite over in the bbs assertion). I had put this generator in shared, but after reviewing the spec it looks like this is now a mandatory D.I. generator so I'll move it to mandatory in a moment. Not sure if adding a new test to D.I. is in the scope of this PR especially with a clean up PR that changes the verify tests a lot looming.

@aljones15
Copy link
Contributor Author

@PatStLouis @tminard I'm going to go ahead and merge this as it was approved before I was aware a test was needed for this. Anyways, I will add the test in a moment.

@aljones15 aljones15 merged commit 3974242 into main Jun 17, 2024
2 checks passed
@aljones15 aljones15 deleted the add-shared-gens branch June 17, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants