Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ServiceWorkerContainer.controller prose says to return undefined, but the IDL doesn't allow that #769

Closed
bzbarsky opened this issue Oct 26, 2015 · 3 comments
Closed

ServiceWorkerContainer.controller prose says to return undefined, but the IDL doesn't allow that #769

bzbarsky opened this issue Oct 26, 2015 · 3 comments
Labels
decided spec detail
Milestone
Version 1

Comments

@bzbarsky
Copy link

The IDL says:

readonly attribute ServiceWorker? controller;

and undefined is not a valid ServiceWorker? value.

What you would probably want is for the property to not exist in a secure context at all, right?
@bzbarsky bzbarsky changed the title ServiceWorkerContainer.controller is prose says to return undefined, but the IDL doesn't allow that ServiceWorkerContainer.controller prose says to return undefined, but the IDL doesn't allow that Oct 26, 2015
@annevk annevk modified the milestone: Version 1 Oct 27, 2015
@jungkees
Copy link
Collaborator

We plan to discuss this in web app security WG meeting what the expected behavior for getter in non-secure context should be. I'll update the spec depending on the result.

@jakearchibald jakearchibald mentioned this issue Jan 20, 2016
Closed
@jakearchibald
Copy link
Contributor

F2F: update spec. Property won't exist in non-secure contexts

jungkees added a commit that referenced this issue Apr 25, 2016
@jungkees
Apply [SecureContext] Web IDL extended attribute
5264a72 
Apply [SecureContext] to navigator.serviceWorker's getter,
ServiceWorkerContainer interface, self.caches's getter, and CacheStorage
interface. By adopting this Web IDL extended attribute, the qualified properties
and the methods won't exist in non-secure contexts.

Fixes #687 #754 #769
@jungkees
Copy link
Collaborator

Closed by 5264a72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
decided spec detail
Projects
None yet
Milestone
Version 1
Development

No branches or pull requests
5 participants
@jakearchibald @slightlyoff @jungkees @bzbarsky @annevk