Change behavior of skipWaiting() #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this, skipWaiting() promises when called multiple times on a waiting worker had different behaviors among each other where the winner waits unitl the Activate is complete while others don't. This makes the behavior consistent by making the Activate be called only once. To achieve that, this removes the steps in skipWaiting() that call the Activate on a waiting worker (so promise resolves right away after setting the skip waiting flag) and simplifies the call sites of the Activate in the Install algorithm. Related issue: #1015.
|
/cc @asutherland |
|
LGTM. Wow, this is so much easier with the simpler formatting 😄 |
|
Yes, LGTM too! Thanks! Also, total agreement with Jake on how awesome it is to be able to read the diffs easily! Three cheers for all involved in the transition to bikeshed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this, skipWaiting() promises when called multiple times on a
waiting worker had different behaviors among each other where the winner
waits unitl the Activate is complete while others don't. This makes the
behavior consistent by making the Activate be called only once. To
achieve that, this removes the steps in skipWaiting() that call the
Activate on a waiting worker (so promise resolves right away after
setting the skip waiting flag) and simplifies the call sites of the
Activate in the Install algorithm.
Related issue: #1015.