Editorial: correct method control flow #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous control flow for the `ServiceWorkerRegistration#update` algorithm did not return a value under certain error conditions. Update the algorithm steps to consistently return the Promise defined to track the status of the operation.
|
Marked as non-substantive for IPR from ash-nazg. |
jungkees
approved these changes
May 29, 2017
jungkees
added a commit
that referenced
this pull request
May 29, 2017
Reviewing the algorithm again, update() method isn't supposed to run in parallel until the update job is scheduled by Run Job algorithm. Necessary changes for the original PR will be addressed separately. This reverts commit 474b57f.
|
@jugglinmike, sorry I didn't recall my intention on the steps of this method reviewing back after a long time and reverted the patch. The update() method isn't actually supposed to go in parallel until the update job that it creates is scheduled by Run Job algorithm later. The issue that you posed in this PR should still be addressed. I'll do that by filing an issue and moving the guarding steps to appropriate places - maybe to the Update algorithm. (Need to check.) |
This was referenced May 29, 2017
jungkees
added a commit
that referenced
this pull request
May 30, 2017
This patch fixes the control flow of registration.update() method such that the algorithm returns a promise rejected with an exception on error conditions. Before this patch, the steps rejected a non-returned promise and aborted the steps right away. Issue raised through #1152.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous control flow for the
ServiceWorkerRegistration#updatealgorithm did not return a value under certain error conditions. Update
the algorithm steps to consistently return the Promise defined to track
the status of the operation.