Adding self.serviceWorker to service workers.

[jakearchibald]

Fixes #1077.

Tests web-platform-tests/wpt#17285

---

Preview | Diff

[mfalken]

This looks great... if it's not too much of a hassle, it might also be worth splitting this into two PRs: one with the "getting the service worker object" algorithm and one that adds self.serviceWorker. For self.serviceWorker, it might be worth pinging the issue or here for more visibility?

[jakearchibald]

if it's not too much of a hassle, it might also be worth splitting this into two PRs: one with the "getting the service worker object" algorithm and one that adds self.serviceWorker

Good point. I'll split it up.

[jakearchibald]

Ok, this is only about self.serviceWorker now. It'll fail to build properly because "getting the service worker object" isn't defined. (update: the other PR merged, so the references work)

[jakearchibald]

Assuming we want self.serviceWorker to always be available, during the very first run of a service worker it won't yet be in the 'installing' state. Looks like we're going to expose the 'parsed' state for the first time.

[jakearchibald]

Tests web-platform-tests/wpt#17285

[mfalken]

Seems OK to expose "parsed". I'm a bit curious now how that name was chosen. Is it better than something like "initial"? Really naive question but is JavaScript specified to do parsing before starting execution?

[jakearchibald]

Seems OK to expose "parsed". I'm a bit curious now how that name was chosen. Is it better than something like "initial"?

I never thought about changing the name. "initial" seems ok. It could also be "pending", "pendingInstall", "beforeInstall", "preinstall".

Really naive question but is JavaScript specified to do parsing before starting execution?

I think there are cases where v8 defers parsing parts of some functions, but the top level has been parsed at this point.

[wanderview]

Right, if there was a syntax error you would not have gotten to the point of executing the script.

[jakearchibald]

I think I'm favouring "preinstall". Anyone hating that?

[jakearchibald]

Let's stick with "parsed". It's past tense like "installed" & "activated".