-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a static routing API support. #1686
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
suggested changes
Jul 11, 2023
I have updated the spec upon comments. |
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 14, 2023
This CL adds the Web Platform Tests to test ServiceWorker static routing API for subresources. Spec PR: w3c/ServiceWorker#1686 Change-Id: I7379d85b5a2208f248878abe9d1a920ad97d47ab Bug: 1371756
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 14, 2023
This CL adds the Web Platform Tests to test ServiceWorker static routing API for subresources. WICG proposal: WICG/proposals#102 Spec PR: w3c/ServiceWorker#1686 Change-Id: I7379d85b5a2208f248878abe9d1a920ad97d47ab Bug: 1371756
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 14, 2023
This CL adds the Web Platform Tests to test ServiceWorker static routing API for subresources. WICG proposal: WICG/proposals#102 Spec PR: w3c/ServiceWorker#1686 Change-Id: I7379d85b5a2208f248878abe9d1a920ad97d47ab Bug: 1371756
domenic
reviewed
Jul 14, 2023
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 18, 2023
This CL adds the Web Platform Tests to test ServiceWorker static routing API for subresources. WICG proposal: WICG/proposals#102 Spec PR: w3c/ServiceWorker#1686 Change-Id: I7379d85b5a2208f248878abe9d1a920ad97d47ab Bug: 1371756
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 18, 2023
This CL adds the Web Platform Tests to test ServiceWorker static routing API for subresources. WICG proposal: WICG/proposals#102 Spec PR: w3c/ServiceWorker#1686 Change-Id: I7379d85b5a2208f248878abe9d1a920ad97d47ab Bug: 1371756
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 18, 2023
This CL adds the Web Platform Tests to test ServiceWorker static routing API for subresources. WICG proposal: WICG/proposals#102 Spec PR: w3c/ServiceWorker#1686 Change-Id: I7379d85b5a2208f248878abe9d1a920ad97d47ab Bug: 1371756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4664026 Reviewed-by: Shunya Shishido <sisidovski@chromium.org> Reviewed-by: Minoru Chikamune <chikamune@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/main@{#1171605}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 18, 2023
This CL adds the Web Platform Tests to test ServiceWorker static routing API for subresources. WICG proposal: WICG/proposals#102 Spec PR: w3c/ServiceWorker#1686 Change-Id: I7379d85b5a2208f248878abe9d1a920ad97d47ab Bug: 1371756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4664026 Reviewed-by: Shunya Shishido <sisidovski@chromium.org> Reviewed-by: Minoru Chikamune <chikamune@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/main@{#1171605}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jul 22, 2023
…r subresource loads., a=testonly Automatic update from web-platform-tests WPT: ServiceWorker static routing API for subresource loads. This CL adds the Web Platform Tests to test ServiceWorker static routing API for subresources. WICG proposal: WICG/proposals#102 Spec PR: w3c/ServiceWorker#1686 Change-Id: I7379d85b5a2208f248878abe9d1a920ad97d47ab Bug: 1371756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4664026 Reviewed-by: Shunya Shishido <sisidovski@chromium.org> Reviewed-by: Minoru Chikamune <chikamune@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/main@{#1171605} -- wpt-commits: d6ae6c83c103fdf28aefd9fb3445470c96c0e17b wpt-pr: 41038
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Jul 24, 2023
…r subresource loads., a=testonly Automatic update from web-platform-tests WPT: ServiceWorker static routing API for subresource loads. This CL adds the Web Platform Tests to test ServiceWorker static routing API for subresources. WICG proposal: WICG/proposals#102 Spec PR: w3c/ServiceWorker#1686 Change-Id: I7379d85b5a2208f248878abe9d1a920ad97d47ab Bug: 1371756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4664026 Reviewed-by: Shunya Shishido <sisidovskichromium.org> Reviewed-by: Minoru Chikamune <chikamunechromium.org> Reviewed-by: Kouhei Ueno <kouheichromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawachromium.org> Reviewed-by: Kent Tamura <tkentchromium.org> Cr-Commit-Position: refs/heads/main{#1171605} -- wpt-commits: d6ae6c83c103fdf28aefd9fb3445470c96c0e17b wpt-pr: 41038 UltraBlame original commit: b5f983a66877126f278d41b511c32f703f62f63d
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Jul 24, 2023
…r subresource loads., a=testonly Automatic update from web-platform-tests WPT: ServiceWorker static routing API for subresource loads. This CL adds the Web Platform Tests to test ServiceWorker static routing API for subresources. WICG proposal: WICG/proposals#102 Spec PR: w3c/ServiceWorker#1686 Change-Id: I7379d85b5a2208f248878abe9d1a920ad97d47ab Bug: 1371756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4664026 Reviewed-by: Shunya Shishido <sisidovskichromium.org> Reviewed-by: Minoru Chikamune <chikamunechromium.org> Reviewed-by: Kouhei Ueno <kouheichromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawachromium.org> Reviewed-by: Kent Tamura <tkentchromium.org> Cr-Commit-Position: refs/heads/main{#1171605} -- wpt-commits: d6ae6c83c103fdf28aefd9fb3445470c96c0e17b wpt-pr: 41038 UltraBlame original commit: b5f983a66877126f278d41b511c32f703f62f63d
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Jul 24, 2023
…r subresource loads., a=testonly Automatic update from web-platform-tests WPT: ServiceWorker static routing API for subresource loads. This CL adds the Web Platform Tests to test ServiceWorker static routing API for subresources. WICG proposal: WICG/proposals#102 Spec PR: w3c/ServiceWorker#1686 Change-Id: I7379d85b5a2208f248878abe9d1a920ad97d47ab Bug: 1371756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4664026 Reviewed-by: Shunya Shishido <sisidovskichromium.org> Reviewed-by: Minoru Chikamune <chikamunechromium.org> Reviewed-by: Kouhei Ueno <kouheichromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawachromium.org> Reviewed-by: Kent Tamura <tkentchromium.org> Cr-Commit-Position: refs/heads/main{#1171605} -- wpt-commits: d6ae6c83c103fdf28aefd9fb3445470c96c0e17b wpt-pr: 41038 UltraBlame original commit: b5f983a66877126f278d41b511c32f703f62f63d
ErichDonGubler
pushed a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Jul 24, 2023
…r subresource loads., a=testonly Automatic update from web-platform-tests WPT: ServiceWorker static routing API for subresource loads. This CL adds the Web Platform Tests to test ServiceWorker static routing API for subresources. WICG proposal: WICG/proposals#102 Spec PR: w3c/ServiceWorker#1686 Change-Id: I7379d85b5a2208f248878abe9d1a920ad97d47ab Bug: 1371756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4664026 Reviewed-by: Shunya Shishido <sisidovski@chromium.org> Reviewed-by: Minoru Chikamune <chikamune@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/main@{#1171605} -- wpt-commits: d6ae6c83c103fdf28aefd9fb3445470c96c0e17b wpt-pr: 41038
yoshisatoyanagisawa
added a commit
to WICG/service-worker-static-routing-api
that referenced
this pull request
Aug 16, 2023
In the recent specification PR (w3c/ServiceWorker#1686), the urlPattern condition accepts URLPatternInput instead of USVString. This CL adjusted the explanation. Also, this CL made RouterCondition to have the urlPattern field for ease of adding other fields as "and" condition.
yoshisatoyanagisawa
force-pushed
the
main
branch
from
November 17, 2023 06:10
cbd47b4
to
4711a07
Compare
yoshisatoyanagisawa
added a commit
to yoshisatoyanagisawa/ServiceWorker
that referenced
this pull request
Nov 28, 2023
I used to work on the specification update to support the ServiceWorker static routing API (https://github.com/WICG/service-worker-static-routing-api) w3c#1686 However, I accidentally closed it by force-sync to the ServiceWorker specification's repository HEAD. This CL is for reviving it.
This has been accidentally removed. I decided to work on the spec update in my personal repository, and will eventually send a PR after work inside the repository finishes. yoshisatoyanagisawa#1 will be the initial step. |
yoshisatoyanagisawa
added a commit
to yoshisatoyanagisawa/ServiceWorker
that referenced
this pull request
Dec 6, 2023
Revive of PR w3c#1686.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A specification update to support the static routing API proposed in WICG/proposals#102
Preview | Diff