Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a static routing API support. #1686

Closed
wants to merge 0 commits into from

Conversation

yoshisatoyanagisawa
Copy link
Contributor

@yoshisatoyanagisawa yoshisatoyanagisawa commented Jul 10, 2023

A specification update to support the static routing API proposed in WICG/proposals#102


Preview | Diff

docs/index.bs Outdated Show resolved Hide resolved
docs/index.bs Outdated Show resolved Hide resolved
docs/index.bs Outdated Show resolved Hide resolved
docs/index.bs Outdated Show resolved Hide resolved
docs/index.bs Outdated Show resolved Hide resolved
docs/index.bs Outdated Show resolved Hide resolved
docs/index.bs Outdated Show resolved Hide resolved
docs/index.bs Outdated Show resolved Hide resolved
docs/index.bs Outdated Show resolved Hide resolved
docs/index.bs Outdated Show resolved Hide resolved
@yoshisatoyanagisawa
Copy link
Contributor Author

I have updated the spec upon comments.
Please take another look at it.

@yoshisatoyanagisawa yoshisatoyanagisawa marked this pull request as ready for review July 13, 2023 00:03
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 14, 2023
This CL adds the Web Platform Tests to test ServiceWorker static
routing API for subresources.

Spec PR: w3c/ServiceWorker#1686

Change-Id: I7379d85b5a2208f248878abe9d1a920ad97d47ab
Bug: 1371756
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 14, 2023
This CL adds the Web Platform Tests to test ServiceWorker static
routing API for subresources.

WICG proposal: WICG/proposals#102
Spec PR: w3c/ServiceWorker#1686

Change-Id: I7379d85b5a2208f248878abe9d1a920ad97d47ab
Bug: 1371756
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 14, 2023
This CL adds the Web Platform Tests to test ServiceWorker static
routing API for subresources.

WICG proposal: WICG/proposals#102
Spec PR: w3c/ServiceWorker#1686

Change-Id: I7379d85b5a2208f248878abe9d1a920ad97d47ab
Bug: 1371756
docs/index.bs Outdated Show resolved Hide resolved
docs/index.bs Outdated Show resolved Hide resolved
docs/index.bs Outdated Show resolved Hide resolved
docs/index.bs Outdated Show resolved Hide resolved
docs/index.bs Outdated Show resolved Hide resolved
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 18, 2023
This CL adds the Web Platform Tests to test ServiceWorker static
routing API for subresources.

WICG proposal: WICG/proposals#102
Spec PR: w3c/ServiceWorker#1686

Change-Id: I7379d85b5a2208f248878abe9d1a920ad97d47ab
Bug: 1371756
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 18, 2023
This CL adds the Web Platform Tests to test ServiceWorker static
routing API for subresources.

WICG proposal: WICG/proposals#102
Spec PR: w3c/ServiceWorker#1686

Change-Id: I7379d85b5a2208f248878abe9d1a920ad97d47ab
Bug: 1371756
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 18, 2023
This CL adds the Web Platform Tests to test ServiceWorker static
routing API for subresources.

WICG proposal: WICG/proposals#102
Spec PR: w3c/ServiceWorker#1686

Change-Id: I7379d85b5a2208f248878abe9d1a920ad97d47ab
Bug: 1371756
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4664026
Reviewed-by: Shunya Shishido <sisidovski@chromium.org>
Reviewed-by: Minoru Chikamune <chikamune@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1171605}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 18, 2023
This CL adds the Web Platform Tests to test ServiceWorker static
routing API for subresources.

WICG proposal: WICG/proposals#102
Spec PR: w3c/ServiceWorker#1686

Change-Id: I7379d85b5a2208f248878abe9d1a920ad97d47ab
Bug: 1371756
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4664026
Reviewed-by: Shunya Shishido <sisidovski@chromium.org>
Reviewed-by: Minoru Chikamune <chikamune@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1171605}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jul 22, 2023
…r subresource loads., a=testonly

Automatic update from web-platform-tests
WPT: ServiceWorker static routing API for subresource loads.

This CL adds the Web Platform Tests to test ServiceWorker static
routing API for subresources.

WICG proposal: WICG/proposals#102
Spec PR: w3c/ServiceWorker#1686

Change-Id: I7379d85b5a2208f248878abe9d1a920ad97d47ab
Bug: 1371756
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4664026
Reviewed-by: Shunya Shishido <sisidovski@chromium.org>
Reviewed-by: Minoru Chikamune <chikamune@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1171605}

--

wpt-commits: d6ae6c83c103fdf28aefd9fb3445470c96c0e17b
wpt-pr: 41038
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Jul 24, 2023
…r subresource loads., a=testonly

Automatic update from web-platform-tests
WPT: ServiceWorker static routing API for subresource loads.

This CL adds the Web Platform Tests to test ServiceWorker static
routing API for subresources.

WICG proposal: WICG/proposals#102
Spec PR: w3c/ServiceWorker#1686

Change-Id: I7379d85b5a2208f248878abe9d1a920ad97d47ab
Bug: 1371756
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4664026
Reviewed-by: Shunya Shishido <sisidovskichromium.org>
Reviewed-by: Minoru Chikamune <chikamunechromium.org>
Reviewed-by: Kouhei Ueno <kouheichromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawachromium.org>
Reviewed-by: Kent Tamura <tkentchromium.org>
Cr-Commit-Position: refs/heads/main{#1171605}

--

wpt-commits: d6ae6c83c103fdf28aefd9fb3445470c96c0e17b
wpt-pr: 41038

UltraBlame original commit: b5f983a66877126f278d41b511c32f703f62f63d
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Jul 24, 2023
…r subresource loads., a=testonly

Automatic update from web-platform-tests
WPT: ServiceWorker static routing API for subresource loads.

This CL adds the Web Platform Tests to test ServiceWorker static
routing API for subresources.

WICG proposal: WICG/proposals#102
Spec PR: w3c/ServiceWorker#1686

Change-Id: I7379d85b5a2208f248878abe9d1a920ad97d47ab
Bug: 1371756
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4664026
Reviewed-by: Shunya Shishido <sisidovskichromium.org>
Reviewed-by: Minoru Chikamune <chikamunechromium.org>
Reviewed-by: Kouhei Ueno <kouheichromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawachromium.org>
Reviewed-by: Kent Tamura <tkentchromium.org>
Cr-Commit-Position: refs/heads/main{#1171605}

--

wpt-commits: d6ae6c83c103fdf28aefd9fb3445470c96c0e17b
wpt-pr: 41038

UltraBlame original commit: b5f983a66877126f278d41b511c32f703f62f63d
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Jul 24, 2023
…r subresource loads., a=testonly

Automatic update from web-platform-tests
WPT: ServiceWorker static routing API for subresource loads.

This CL adds the Web Platform Tests to test ServiceWorker static
routing API for subresources.

WICG proposal: WICG/proposals#102
Spec PR: w3c/ServiceWorker#1686

Change-Id: I7379d85b5a2208f248878abe9d1a920ad97d47ab
Bug: 1371756
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4664026
Reviewed-by: Shunya Shishido <sisidovskichromium.org>
Reviewed-by: Minoru Chikamune <chikamunechromium.org>
Reviewed-by: Kouhei Ueno <kouheichromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawachromium.org>
Reviewed-by: Kent Tamura <tkentchromium.org>
Cr-Commit-Position: refs/heads/main{#1171605}

--

wpt-commits: d6ae6c83c103fdf28aefd9fb3445470c96c0e17b
wpt-pr: 41038

UltraBlame original commit: b5f983a66877126f278d41b511c32f703f62f63d
ErichDonGubler pushed a commit to erichdongubler-mozilla/firefox that referenced this pull request Jul 24, 2023
…r subresource loads., a=testonly

Automatic update from web-platform-tests
WPT: ServiceWorker static routing API for subresource loads.

This CL adds the Web Platform Tests to test ServiceWorker static
routing API for subresources.

WICG proposal: WICG/proposals#102
Spec PR: w3c/ServiceWorker#1686

Change-Id: I7379d85b5a2208f248878abe9d1a920ad97d47ab
Bug: 1371756
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4664026
Reviewed-by: Shunya Shishido <sisidovski@chromium.org>
Reviewed-by: Minoru Chikamune <chikamune@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1171605}

--

wpt-commits: d6ae6c83c103fdf28aefd9fb3445470c96c0e17b
wpt-pr: 41038
yoshisatoyanagisawa added a commit to WICG/service-worker-static-routing-api that referenced this pull request Aug 16, 2023
In the recent specification PR (w3c/ServiceWorker#1686), the urlPattern condition accepts URLPatternInput instead of USVString.  This CL adjusted the explanation.

Also, this CL made RouterCondition to have the urlPattern field
for ease of adding other fields as "and" condition.
yoshisatoyanagisawa added a commit to yoshisatoyanagisawa/ServiceWorker that referenced this pull request Nov 28, 2023
I used to work on the specification update to support the
ServiceWorker static routing API
(https://github.com/WICG/service-worker-static-routing-api)
w3c#1686

However, I accidentally closed it by force-sync to the ServiceWorker
specification's repository HEAD.

This CL is for reviving it.
@yoshisatoyanagisawa
Copy link
Contributor Author

This has been accidentally removed. I decided to work on the spec update in my personal repository, and will eventually send a PR after work inside the repository finishes.

yoshisatoyanagisawa#1 will be the initial step.

yoshisatoyanagisawa added a commit to yoshisatoyanagisawa/ServiceWorker that referenced this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants