Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Update link texts upon updates in the URLPattern specification #1707

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

yoshisatoyanagisawa
Copy link
Contributor

@yoshisatoyanagisawa yoshisatoyanagisawa commented Mar 4, 2024

Updates in the URLPattern specification was requested during the #1701 review.

The issues for the request has been resolved:

However, during the specification updates, the algorithm names are also updated and arguments are changed.
This is adjustments for them.


Preview | Diff

Updates in the URLPattern specification was requested during the
w3c#1701 review.

The issues for the request has been resolved:
- whatwg/urlpattern#217
- whatwg/urlpattern#218

However, during the specification updates, the algorithm names are also
updated, and adjustment is needed.
@yoshisatoyanagisawa
Copy link
Contributor Author

@mkruisselbrink This simply fixes the broken links to the URLPattern specification. Will you take a look? Thank you.

@yoshisatoyanagisawa yoshisatoyanagisawa changed the title Update link texts upon updates in the URLPattern specification Editorial: Update link texts upon updates in the URLPattern specification Mar 7, 2024
@yoshisatoyanagisawa
Copy link
Contributor Author

I guess I should add prefix "Editorial:" for this kind of changes.

@yoshisatoyanagisawa
Copy link
Contributor Author

@domenic Can I ask you to take a look?

Copy link
Contributor

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit

docs/index.bs Outdated Show resolved Hide resolved
Co-authored-by: Domenic Denicola <d@domenic.me>
@yoshisatoyanagisawa
Copy link
Contributor Author

@domenic Thank you for the review.
@mkruisselbrink Can I have the owner's lgtm?

@mkruisselbrink mkruisselbrink merged commit e89eaed into w3c:main Mar 13, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Mar 13, 2024
…tion (#1707)

SHA: e89eaed
Reason: push, by mkruisselbrink

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to asleekgeek/ServiceWorker that referenced this pull request Mar 14, 2024
…tion (w3c#1707)

SHA: e89eaed
Reason: push, by pull[bot]

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@yoshisatoyanagisawa yoshisatoyanagisawa deleted the urlpattern branch March 19, 2024 03:59
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants