Adapt to virtual sensor changes in w3c/sensors#475 #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakuco
force-pushed
the
adapt-to-automation-changes
branch
from
14a7f3c
to
ddef3fc
Compare
reillyeon
requested changes
Nov 27, 2023
The PR above removed the "virtual sensor type" item from the "virtual sensor metadata" struct and turned it into a string that is referenced from the automation bits as well as (optionally) defined by a sensor type. Adapt to it here by removing mentions of `[=virtual sensor metadata/virtual sensor type=]` from the spec and adding virtual sensor types to each sensor type defined here.
rakuco
force-pushed
the
adapt-to-automation-changes
branch
from
ddef3fc
to
941d6f3
Compare
reillyeon
approved these changes
Nov 28, 2023
github-actions bot
added a commit
that referenced
this pull request
Nov 28, 2023
SHA: 7fd366f Reason: push, by reillyeon Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR above removed the "virtual sensor type" item from the "virtual sensor
metadata" struct and turned it into a string that is referenced from the
automation bits as well as (optionally) defined by a sensor type.
Adapt to it here by removing mentions of
[=virtual sensor metadata/virtual sensor type=]from the spec and adding virtual sensor types to each sensortype defined here.
Preview | Diff