-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review section on role presentation #176
Comments
Suggested edit: |
Not good to use the term as it's definition, so suggested edit: |
Suggested edit: |
The following is confusing:
Does that mean the browser doesn't honor role="presentation"? If you choose to retain the original text, then both bullets need to either start with a capital letter or both bullets need to start with a lower case letter. |
Target needed for link in following sentence: It currently directs to a 404 file not found error. |
CHANGE: I also think it would be good to enclose "tablist" in a code element, it will sand out visually. |
I suggest a little restructuring of the items to make some of the rule visible in the TOC and as headings. 6.1 Presentation is ignored for focusable Items and global ARIA attributes
6.2 How Presentation changes content to assistive technologies
6.3 When Presentation is inherited For example:
|
Matt the previous edits I think provide more concrete examples to an author and also makes the "rules" visible as headers. Hope this helps. Jon |
modified: aria-practices.html. Made revisions and corrections in section titled: "Intentionally Hiding Semantics with the presentation Role" In response to 4 of the comments from @annabbott and one of the comments from @jongund in issue #176.
@annabbott and @jongund, thank you very much for the feedback. I have incorporated most of it. @jongund, I played with the idea of changing the format to one that breaks the rules into several separate sections like you have suggested. To me, it does not seem to add clarity or improve brevity. And, I question whether there is benefit to having the rules themselves in the TOC. Attempting to capture the essence of the rule in a headline can create ambiguities that cause a potentially incorrect understanding to stick. |
Suggesting edit: "The roles, states, and properties of descendant elements remain visible to assistive technologies except for the descendant elements that can only exist in the context of the presentational element." Change to: "The roles, states, and properties of descendant elements remain visible to assistive technologies except for the descendant elements that require an ancestor element with a specific role." |
@jessebeach, I kind of like the form you suggest better, but need to make it accurate in this case:
The descendant tr requires a specific ancestor role but it will not be presentational because it does not require the role of the ancestor that is marked presentational. And in this case:
In this case, li 1 is presentational and li 2 is not. They both require the specific implied ancestor role of list. But, when I fix this issue, I get back to nearly the same statement I previously had:
Is that better than the original:
|
What if you try switching the subject to the descendant elements? Something like:
|
modified aria-practices.html: In section titled "Effects of Role presentation", revised wording of effect three based on feedback in issue #176 from @jessebeach and @tatermelon.
I think the current wording reads more like a spec than authoring guidance for people trying to learn this stuff. I don't think calling the concepts rules is very inviting to people trying to learn this stuff, the more straight forward we can make it the easier it will be for them to understand the basic principles of using "presentation". In this case two important concepts "presentation" is ignored when an item is focusable or has gloabla properties and states, and second "presentation" can be inherited by other elements with default semantics. So these should be headers in my opinion. |
The update looks really good, thanks for all your work |
The menu button, menu and tree examples with links now use role="none" in the examples, so you can point to them it you want |
No, it's still not there. I'm confused because it makes me think that ancestor elements that had a role and are then marked as "presentation" now have required descendants. It implies that presentational elements have required descendants. At least for a table, isn't the situation the same as me putting a |
Thank you all for the reviews of this section. I dreamed of making presentation so straight forward anyone will understand it in a matter of a couple of minutes. what a dream. Even though I didn't quite achieve that lofty ambition, I think it is close enough that I can consider this section done for now. |
modified aria-practices.html: Remove link to issue #176 from presentation_role section.
Please review this new
section describing the presentation role.
Requested reviews
The text was updated successfully, but these errors were encountered: